rdblue commented on a change in pull request #2680:
URL: https://github.com/apache/iceberg/pull/2680#discussion_r717682742
##########
File path: core/src/main/java/org/apache/iceberg/avro/ValueWriters.java
##########
@@ -238,6 +238,8 @@ public void write(Object s, Encoder encoder) throws
IOException {
encoder.writeString((Utf8) s);
} else if (s instanceof String) {
encoder.writeString(new Utf8((String) s));
+ } else if (s instanceof CharSequence) {
+ encoder.writeString((CharSequence) s);
Review comment:
Why is this needed? We generally want to avoid writing `CharSequence`
directly because it will require conversion.
##########
File path: core/src/main/java/org/apache/iceberg/util/StructLikeMapUtil.java
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.util;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Map;
+import org.apache.iceberg.StructLike;
+import org.apache.iceberg.types.Types;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class StructLikeMapUtil {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(StructLikeMap.class);
+ private static final String ROCKSDB_DIR_PREFIX = "iceberg-rocksdb-";
+
+ public static final String IMPL = "spill-disk-impl";
+ public static final String IN_MEMORY_MAP = "in-memory";
+ public static final String ROCKSDB_MAP = "rocksdb";
+ public static final String ROCKSDB_DIR = "rocksdb-dir";
+
+ private StructLikeMapUtil() {
+ }
+
+ public static Map<StructLike, StructLike> load(Types.StructType keyType,
+ Types.StructType valType,
+ Map<String, String>
properties) {
Review comment:
I don't think that this is a good option for controlling whether this
feature is turned on. Passing generic properties all the way down to a factory
method for a specific class isn't a good option. Instead, the calling code
should decide which map to use. We want to limit where we pass property maps.
##########
File path: core/src/main/java/org/apache/iceberg/types/Serializers.java
##########
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.types;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.ByteBuffer;
+import java.util.List;
+import java.util.Map;
+import java.util.function.IntFunction;
+import org.apache.iceberg.StructLike;
+import org.apache.iceberg.data.GenericRecord;
+import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+import org.apache.iceberg.util.ByteBuffers;
+
+public class Serializers {
Review comment:
What is the scope of this class? What will use it and how do we avoid
exposing it in a confusing way in the API?
Don't we have other methods of serializing data that should be sufficient?
##########
File path: core/src/main/java/org/apache/iceberg/types/Serializer.java
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.types;
+
+public interface Serializer<T> {
+ byte[] serialize(T object);
Review comment:
Is it necessary to use `byte[]`? Normally we use `ByteBuffer` to avoid
the copies necessarily introduced by `byte[]`.
##########
File path: core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java
##########
@@ -216,6 +231,41 @@ public String toString() {
.add("row_offset", rowOffset)
.toString();
}
+
+ @Override
+ public int size() {
+ return 2;
+ }
+
+ @Override
+ public <T> T get(int pos, Class<T> javaClass) {
+ switch (pos) {
+ case 0:
+ return javaClass.cast(path);
+ case 1:
+ return javaClass.cast(rowOffset);
+ default:
+ throw new UnsupportedOperationException("Unknown field ordinal: " +
pos);
+ }
+ }
+
+ private void put(int pos, Object value) {
+ switch (pos) {
+ case 0:
+ this.path = (CharSequence) value;
+ break;
+ case 1:
+ this.rowOffset = (long) value;
+ break;
+ default:
+ throw new UnsupportedOperationException("Unknown field ordinal: " +
pos);
+ }
+ }
+
+ @Override
+ public <T> void set(int pos, T value) {
+ put(pos, value);
Review comment:
Why use a private `put` method instead of moving the switch here in
`set`? Won't this need a `SuppressWarnings` either way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
