rdblue commented on a change in pull request #3204:
URL: https://github.com/apache/iceberg/pull/3204#discussion_r719735095
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java
##########
@@ -97,11 +103,13 @@ public RewriteFiles validateFromSnapshot(long snapshotId) {
return this;
}
+ @Override
+ public RewriteFiles setSequenceNumber(long sequenceNumber) {
+ this.replaceSequenceNumber = sequenceNumber;
+ return this;
+ }
+
@Override
protected void validate(TableMetadata base) {
- if (replacedDataFiles.size() > 0) {
- // if there are replaced data files, there cannot be any new row-level
deletes for those data files
- validateNoNewDeletesForDataFiles(base, startingSnapshotId,
replacedDataFiles);
- }
Review comment:
This should not be removed. There is a valid use case for the operation
to check whether there are conflicts instead of re-sequencing data files. If
you want, you can add a configuration method to enable/disable the validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
