rdblue commented on a change in pull request #3204:
URL: https://github.com/apache/iceberg/pull/3204#discussion_r719757359
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java
##########
@@ -44,6 +45,11 @@ protected String operation() {
return DataOperations.REPLACE;
}
+ @Override
+ protected Long sequenceNumber() {
+ return replaceSequenceNumber;
Review comment:
With this approach, I think we need a validation that none of the data
or delete files that are being replaced have sequence numbers newer than the
override sequence number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
