RussellSpitzer commented on a change in pull request #3215:
URL: https://github.com/apache/iceberg/pull/3215#discussion_r721378333
##########
File path: core/src/main/java/org/apache/iceberg/util/Tasks.java
##########
@@ -145,7 +144,8 @@ public Builder(Iterable<I> items) {
return this;
}
- public Builder<I> stopRetryOn(Class<? extends Exception>... exceptions) {
+ @SafeVarargs
Review comment:
I wonder if we really should just ignore this warning, I'm trying to
figure out if we really want this class to be extendable or not. If we start
making the var-arg methods final are we making the class un-extendable? This is
fine for now though, I think in particular this method wouldn't ever be
extended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
