RussellSpitzer commented on a change in pull request #3215:
URL: https://github.com/apache/iceberg/pull/3215#discussion_r721383474



##########
File path: core/src/main/java/org/apache/iceberg/util/Tasks.java
##########
@@ -213,7 +214,7 @@ public boolean run(Task<I, RuntimeException> task) {
           try {
             runTaskWithRetry(task, item);
             succeeded.add(item);
-
+            threw = false;

Review comment:
       I'm not sure I follow, 
   
   We have
   
   While (items) 
     try to do something
     catch failure and try to handle
   done
   No breakthrough exceptions for any items threw = false




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to