ggershinsky commented on pull request #3053: URL: https://github.com/apache/iceberg/pull/3053#issuecomment-934356218
> I think this will be easier to review if we break it into some chunks. I was thinking after doing a first pass that maybe it makes sense to break this into > > 1. Encryptors - Non Iceberg Specific Encryption Config and Methods > The code for encrypting and decrypting bytes > Ciphers.java > EncryptionAlgorithm.java > NativeFileEncryptParameters > .... > 2. Parquet Encryption > Files and code relating to writing encrypted Parquet Files > 3. Iceberg Encryption Management > a. Envelope Metadata and Manger > b. OutputStreams and the ability to actually turn on encryption > > I think this would speed up review a lot. If you have other break points to divide up the review I think that would also help. It would also make it easier for us to determine where test coverage should exist. > > I'm really excited by this PR and it will be a great step forward for Iceberg! Thanks Russell! This proposal sounds good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
