samredai commented on a change in pull request #3252:
URL: https://github.com/apache/iceberg/pull/3252#discussion_r725295494
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
##########
@@ -118,6 +122,37 @@ public void testCreateTableWithCaching() throws Exception {
}
}
+ @Test
+ public void testNoArgConstructor() throws Exception {
+ Catalog catalog = new HiveCatalog();
+ }
+
+ @Test
+ public void testSetConf() throws Exception {
+ HiveCatalog catalog = new HiveCatalog();
+ Configuration hadoopConfiguration = new Configuration();
+ catalog.setConf(hadoopConfiguration);
+ }
+
+ @Test
+ public void testInitialize() throws Exception {
+
+ HiveCatalog catalog = Mockito.spy(HiveCatalog.class);
+ Configuration mockHadoopConfiguration = Mockito.mock(Configuration.class);
+ CachedClientPool mockCachedClientPool =
Mockito.mock(CachedClientPool.class);
+
+ Mockito.doNothing().when(catalog).setConf(any());
+ Mockito.doReturn(mockCachedClientPool).when(catalog)
+ .makeCachedClientPool(any(), any());
+ Mockito.doReturn("test").when(mockHadoopConfiguration).get(any());
+
+ catalog.setConf(mockHadoopConfiguration);
+ catalog.initialize("test", Collections.<String, String>emptyMap());
+
+ Mockito.verify(catalog, Mockito.times(1)).makeCachedClientPool(any(),
any());
+ Assert.assertEquals(catalog.name(), "test");
Review comment:
Just to be sure, I packaged the following scala code which ran without
issue in 0.12.x
```scala
import org.apache.iceberg.hive.HiveCatalog;
import org.apache.spark.sql.SparkSession;
object Simple {
def main(args: Array[String]){
val spark = SparkSession.builder.appName("Simple").getOrCreate()
val catalog = new HiveCatalog()
catalog.setConf(spark.sparkContext.hadoopConfiguration)
}
}
```
so the issue in 0.12.x is just contained to any kind of REPL use or if the
user explicitly calls `toString()` in their code for some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
