samredai commented on a change in pull request #3252:
URL: https://github.com/apache/iceberg/pull/3252#discussion_r725496509
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
##########
@@ -118,6 +121,36 @@ public void testCreateTableWithCaching() throws Exception {
}
}
+ @Test
+ public void testInitializeWithConfig() throws Exception {
+ Map<String, String> properties = new HashMap<>();
+ HiveCatalog catalog = new HiveCatalog();
+ catalog.setConf(conf);
+ catalog.initialize("hive", properties);
Review comment:
Great point, I can test name and maybe the type of the conf attribute
(starting to feel like I'm just testing setters and getters here, hehe). I'm
going to focus these in a bit more to clearly test for:
1. Initializing properly when a config is set
2. Throwing properly when initializing without a config (lmk if a scenario
exists where this shouldn't raise!)
3. Not throwing when toString() is used before a config is set (the REPL
case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
