rdblue commented on a change in pull request #3249:
URL: https://github.com/apache/iceberg/pull/3249#discussion_r725681727
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -140,10 +162,18 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
vectorizedColumnIterator.fixedLengthDecimalBatchReader().nextBatch(vec,
typeWidth, nullabilityHolder);
break;
case INT_BACKED_DECIMAL:
-
vectorizedColumnIterator.intBackedDecimalBatchReader().nextBatch(vec, -1,
nullabilityHolder);
+ if (useIntVectorForIntBackedDecimal) {
Review comment:
I don't think this should check the property. It should check the
destination vector's type and use the appropriate reader for the vector. That
way only allocation needs to worry about this configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
