rdblue commented on a change in pull request #3249:
URL: https://github.com/apache/iceberg/pull/3249#discussion_r725682143
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java
##########
@@ -75,7 +75,8 @@
.project(expectedSchema)
.split(task.start(), task.length())
.createBatchedReaderFunc(fileSchema ->
VectorizedSparkParquetReaders.buildReader(expectedSchema,
- fileSchema, /* setArrowValidityVector */
NullCheckingForGet.NULL_CHECKING_ENABLED, idToConstant))
+ fileSchema, /* setArrowValidityVector */
NullCheckingForGet.NULL_CHECKING_ENABLED, idToConstant,
+ true, true))
Review comment:
Why does `VectorizedSparkParquetReaders` expose boolean properties? I
think it should set them internally instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
