hameizi commented on pull request #3204: URL: https://github.com/apache/iceberg/pull/3204#issuecomment-939736573
@rdblue I commit one new commit for your suggestion, can you help review one more time? The fix detail as follows: 1.add one configuration to config whether vaildate there is new delete files be added when compacting files. 2.change name sequenceNumber to sequenceNumberOverride 3.update documentation for method setSequenceNumber > With this approach, I think we need a validation that none of the data or delete files that are being replaced have sequence numbers newer than the override sequence number. The override sequence number is init when compact action generate fileScanTasks in https://github.com/apache/iceberg/pull/3204/files#:~:text=long%20sequenceNumber%20%3D%20table.currentSnapshot().sequenceNumber()%3B, so it can guarantee that none of the data or delete files that are being replaced have sequence numbers newer than the override sequence number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
