openinx commented on a change in pull request #3288: URL: https://github.com/apache/iceberg/pull/3288#discussion_r728586259
########## File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/AliyunOSSURI.java ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aliyun.oss; + +import com.aliyun.oss.internal.OSSUtils; +import java.util.Set; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; + +/** + * This class represents a fully qualified location in OSS for input/output + * operations expressed as as URI. This implementation is provided to + * ensure compatibility with Hadoop Path implementations that may introduce + * encoding issues with native URI implementation. + * + * Note: Path-style access is deprecated and not supported by this + * implementation. + */ +public class AliyunOSSURI { Review comment: I don't think every class in this `iceberg-aliyun` module need a constant `Aliyun` prefix, because: 1. It is put into the `iceberg-aliyun` package, there's no possible that we will access the different vendor's OSSURI in the same place because both of them are implementing the `FileIO` interface and we only need to use `FileIO` API to access the object storage. 2. The full qualifier `org.apache.iceberg.aliyun.oss.OSSURI` has implied the `OSSURI` came from aliyun vendor. So we don't need an redundant prefix `Aliyun` in the `AliyunOSSURI` to address the same thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
