openinx commented on a change in pull request #3288: URL: https://github.com/apache/iceberg/pull/3288#discussion_r731604076
########## File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSURI.java ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aliyun.oss; + +import com.aliyun.oss.internal.OSSUtils; +import java.util.Set; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; + +/** + * This class represents a fully qualified location in OSS for input/output + * operations expressed as as URI. This implementation is provided to + * ensure compatibility with Hadoop Path implementations that may introduce + * encoding issues with native URI implementation. + * + * Note: Path-style access is deprecated and not supported by this + * implementation. + */ +public class OSSURI { + private static final String SCHEME_DELIM = "://"; + private static final String PATH_DELIM = "/"; + private static final String QUERY_DELIM = "\\?"; + private static final String FRAGMENT_DELIM = "#"; + private static final Set<String> VALID_SCHEMES = ImmutableSet.of("https", "oss"); + private final String location; + private final String bucket; + private final String key; + + /** + * Creates a new OSSURI based on the bucket and key parsed from the location + * The location in string form has the syntax as below, which refers to RFC2396: + * [scheme:][//bucket][object key][#fragment] + * [scheme:][//bucket][object key][?query][#fragment] + * + * It specifies precisely which characters are permitted in the various components of a URI reference + * in Aliyun OSS documentation as below: + * Bucket: https://help.aliyun.com/document_detail/257087.html + * Object: https://help.aliyun.com/document_detail/273129.html + * Scheme: https or oss + * + * <p> + * Supported access styles are https and oss://... URIs. + * + * @param location fully qualified URI. + */ + public OSSURI(String location) { + Preconditions.checkNotNull(location, "OSS location cannot be null."); + + this.location = location; + String[] schemeSplit = location.split(SCHEME_DELIM, -1); + ValidationException.check(schemeSplit.length == 2, "Invalid OSS location: %s", location); + + String scheme = schemeSplit[0]; + ValidationException.check(VALID_SCHEMES.contains(scheme.toLowerCase()), "Invalid scheme: %s", scheme); Review comment: I will suggest to add `location` in the error message so that we could locate the cause easily if scheme is mismatched. `Invalid schema %s in OSS locattion: %s` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
