rdblue commented on a change in pull request #3275:
URL: https://github.com/apache/iceberg/pull/3275#discussion_r731153011
##########
File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java
##########
@@ -155,10 +156,11 @@ private void updateTable(String newMetadataLocation,
String oldMetadataLocation)
}
private void createTable(String newMetadataLocation) throws SQLException,
InterruptedException {
+ Namespace tableNamespace = tableIdentifier.namespace();
int insertRecord = connections.run(conn -> {
try (PreparedStatement sql =
conn.prepareStatement(JdbcUtil.DO_COMMIT_CREATE_TABLE_SQL)) {
sql.setString(1, catalogName);
- sql.setString(2,
JdbcUtil.namespaceToString(tableIdentifier.namespace()));
+ sql.setString(2, JdbcUtil.namespaceToString(tableNamespace));
Review comment:
The changes to this file don't seem to be functional. Can you revert
them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
