rdblue commented on a change in pull request #3335:
URL: https://github.com/apache/iceberg/pull/3335#discussion_r734103100
##########
File path: .github/workflows/spark-ci.yml
##########
@@ -98,3 +98,30 @@ jobs:
name: test logs
path: |
**/build/testlogs
+
+ spark-32-tests:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jvm: [11]
+ spark: ['3.2']
+ env:
+ SPARK_LOCAL_IP: localhost
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.jvm }}
+ - uses: actions/cache@v2
+ with:
+ path: ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
+ restore-keys: ${{ runner.os }}-gradle
+ - run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
+ - run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DhiveVersions=
-DflinkVersions= :iceberg-spark:iceberg-spark-32:check
:iceberg-spark:iceberg-spark-32-extensions:check
:iceberg-spark:iceberg-spark-32-runtime:check -Pquick=true -x javadoc
Review comment:
I'd prefer to use the `spark_3.2_2.12` naming scheme for modules. That
would allow us to parameterize this with another reference to `${{ matrix.spark
}}` when calling the Spark version module's `check` task. Similarly, we'd be
able to support Scala version in a follow-up.
I think the main argument for a module named `iceberg-spark32` is
consistency with the existing module names, but I don't think they are
something we want to preserve now that we have more than modules for Spark
major versions. It is more clear to use `_3.2_2.13` everywhere that we can, vs
relying on people knowing that `32` is actually Spark 3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
