wypoon commented on a change in pull request #3335:
URL: https://github.com/apache/iceberg/pull/3335#discussion_r734220416
##########
File path: .github/workflows/spark-ci.yml
##########
@@ -98,3 +98,30 @@ jobs:
name: test logs
path: |
**/build/testlogs
+
+ spark-32-tests:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jvm: [11]
+ spark: ['3.2']
+ env:
+ SPARK_LOCAL_IP: localhost
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.jvm }}
+ - uses: actions/cache@v2
+ with:
+ path: ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
+ restore-keys: ${{ runner.os }}-gradle
+ - run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
+ - run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DhiveVersions=
-DflinkVersions= :iceberg-spark:iceberg-spark-32:check
:iceberg-spark:iceberg-spark-32-extensions:check
:iceberg-spark:iceberg-spark-32-runtime:check -Pquick=true -x javadoc
Review comment:
I'm fine with using `_3.2_2.12` and `_3.2_2.13` names for the modules.
For a developer running gradle locally on their machine, is there a single
`./gradlew` command that they can use with `-DsparkVersions=3.0,3.2` or
`-DsparkVersions=3.2` that builds all the applicable Spark 3 modules or runs
their tests (less general than `build` or `check` or `build -x test`)?
Regardless of the naming of the modules, can we still keep the subdirectory
names under each Spark 3 version uniform? It's independent of the module names
and I think it'd be good if the subdirectory names are the same for each
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
