rdblue commented on a change in pull request #3275:
URL: https://github.com/apache/iceberg/pull/3275#discussion_r735008962
##########
File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
##########
@@ -69,6 +70,33 @@
" (" + CATALOG_NAME + ", " + TABLE_NAMESPACE + ", " + TABLE_NAME +
", " + METADATA_LOCATION + ", " + PREVIOUS_METADATA_LOCATION + ") " +
" VALUES (?,?,?,?,null)";
+
+ // Catalog Namespace Properties
+ protected static final String NAMESPACE_PROPERTIES_TABLE_NAME =
"iceberg_namespace_properties";
+ protected static final String NAMESPACE_NAME = "namespace_name";
Review comment:
I don't think that `namespace_name` is a good name because "namespace"
is usually a type of name in itself. I'd just go with "namespace" instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
