nssalian commented on a change in pull request #3275:
URL: https://github.com/apache/iceberg/pull/3275#discussion_r735046661
##########
File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
##########
@@ -69,6 +73,38 @@
" (" + CATALOG_NAME + ", " + TABLE_NAMESPACE + ", " + TABLE_NAME +
", " + METADATA_LOCATION + ", " + PREVIOUS_METADATA_LOCATION + ") " +
" VALUES (?,?,?,?,null)";
+
+ // Catalog Namespace
+ protected static final String CATALOG_NAMESPACE_TABLE_NAME =
"iceberg_namespaces";
+ protected static final String NAMESPACE_NAME = "namespace_name";
+ protected static final String NAMESPACE_METADATA = "metadata";
+ protected static final String NAMESPACE_PROPERTIES_TABLE_NAME =
"namespace_properties";
+ protected static final String NAMESPACE_PROPERTY_KEY = "key";
+ protected static final String NAMESPACE_PROPERTY_VALUE = "value";
+
+ protected static final String CREATE_NAMESPACE_TABLE =
+ "CREATE TABLE " + CATALOG_NAMESPACE_TABLE_NAME +
+ "(" +
+ CATALOG_NAME + " VARCHAR(255) NOT NULL," +
+ NAMESPACE_NAME + " VARCHAR(255) NOT NULL," +
+ NAMESPACE_METADATA + " VARCHAR(65535)," +
Review comment:
Curious, why are they `metadata` and `properties` named differently if
they mean the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
