mayursrivastava commented on a change in pull request #3294:
URL: https://github.com/apache/iceberg/pull/3294#discussion_r735202751



##########
File path: 
core/src/main/java/org/apache/iceberg/io/inmemory/InMemoryFileStore.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.io.inmemory;
+
+import java.util.Collection;
+import java.util.Optional;
+
+/**
+ * An interface for in-memory collection-based key-value storage
+ * for byte arrays keyed by string location.
+ * The string location can be optionally converted to a custom
+ * canonical location specified by the user.
+ */
+public interface InMemoryFileStore {

Review comment:
       Initially, I wanted to create multiple implementations of this class and 
also allow users to do so. But, at the moment, I don't have any concrete plans 
to do so. I'll remove ```public``` from the interface. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to