aokolnychyi commented on a change in pull request #3369:
URL: https://github.com/apache/iceberg/pull/3369#discussion_r735748772
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -212,33 +220,44 @@ private String getRowLevelOperationMode(String operation)
{
@Override
public boolean canDeleteWhere(Filter[] filters) {
Review comment:
This implementation is just an idea of what can be done. It makes the
check way more expensive than before but also allows us to cover more scenarios
(e.g. deletes with transforms, deletes using metrics, deletes with multiple
specs).
We may consider a flag or something to disable it but I am not sure at this
point. Maybe, there are better ideas. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
