RussellSpitzer commented on a change in pull request #3369:
URL: https://github.com/apache/iceberg/pull/3369#discussion_r735758930
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -212,33 +220,44 @@ private String getRowLevelOperationMode(String operation)
{
@Override
public boolean canDeleteWhere(Filter[] filters) {
Review comment:
I am wondering if it makes sense to do this sort of metadata delete
inside the non-metadata delete path and here instead just do a check as to
whether or not a metadata delete is even possible? Like instead of checking to
to see whether any metadata delete can be done, make sure a metadata delete
cannot be done.
See if the delete conditions could not possibly apply to all the specs
currently in play, rather than checking to see if they can apply to all live
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
