rdblue commented on a change in pull request #3015:
URL: https://github.com/apache/iceberg/pull/3015#discussion_r735835679
##########
File path: api/src/main/java/org/apache/iceberg/DataFile.java
##########
@@ -62,18 +62,20 @@
Types.NestedField EQUALITY_IDS = optional(135, "equality_ids",
ListType.ofRequired(136, IntegerType.get()),
"Equality comparison field IDs");
Types.NestedField SORT_ORDER_ID = optional(140, "sort_order_id",
IntegerType.get(), "Sort order ID");
+ Types.NestedField SPEC_ID = optional(141, "spec_id", IntegerType.get(),
"Partition spec ID");
int PARTITION_ID = 102;
String PARTITION_NAME = "partition";
String PARTITION_DOC = "Partition data tuple, schema based on the partition
spec";
- // NEXT ID TO ASSIGN: 141
+ // NEXT ID TO ASSIGN: 142
static StructType getType(StructType partitionType) {
// IDs start at 100 to leave room for changes to ManifestEntry
return StructType.of(
CONTENT,
FILE_PATH,
FILE_FORMAT,
+ SPEC_ID,
Review comment:
This doesn't actually write the spec ID into manifest files, right? I
don't think it would without a change to the V1/V2 write wrappers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
