rdblue commented on a change in pull request #3015:
URL: https://github.com/apache/iceberg/pull/3015#discussion_r735838832
##########
File path: api/src/main/java/org/apache/iceberg/DataFile.java
##########
@@ -62,18 +62,20 @@
Types.NestedField EQUALITY_IDS = optional(135, "equality_ids",
ListType.ofRequired(136, IntegerType.get()),
"Equality comparison field IDs");
Types.NestedField SORT_ORDER_ID = optional(140, "sort_order_id",
IntegerType.get(), "Sort order ID");
+ Types.NestedField SPEC_ID = optional(141, "spec_id", IntegerType.get(),
"Partition spec ID");
Review comment:
I think we need to update the spec since we are assigning a new field ID
here. We should at least note that it is reserved, even though we don't write
it into data files. We can do that in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
