kbendick commented on a change in pull request #3373:
URL: https://github.com/apache/iceberg/pull/3373#discussion_r736875964
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalog.java
##########
@@ -30,14 +33,14 @@
@Override
public Table loadTable(Identifier ident) throws NoSuchTableException {
- String[] parts = ident.name().split("\\$", 2);
- if (parts.length == 2) {
- TestTables.TestTable table = TestTables.load(parts[0]);
- String[] metadataColumns = parts[1].split(",");
- return new SparkTestTable(table, metadataColumns, false);
- } else {
- TestTables.TestTable table = TestTables.load(ident.name());
- return new SparkTestTable(table, null, false);
+ TableIdentifier tableIdentifier =
Spark3Util.identifierToTableIdentifier(ident);
+ Namespace namespace = tableIdentifier.namespace();
+
+ TestTables.TestTable table = TestTables.load(tableIdentifier.toString());
+ if (table == null && namespace.equals(Namespace.of("default"))) {
+ table = TestTables.load(tableIdentifier.name());
}
+
+ return new SparkTable(table, false);
Review comment:
If `table` is `null` but namespace isn't default, what will happen here?
I guess since this is for testing it's not as much of a concern, but should
we throw `NoSuchTableException` anyways to help out test authors (or do I
possibly have that completely confused)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
