aokolnychyi commented on a change in pull request #3373:
URL: https://github.com/apache/iceberg/pull/3373#discussion_r739887043
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -168,6 +174,17 @@ public StructType schema() {
return CAPABILITIES;
}
+ @Override
+ public MetadataColumn[] metadataColumns() {
+ DataType sparkPartitionType =
SparkSchemaUtil.convert(Partitioning.partitionType(table()));
+ return new MetadataColumn[] {
+ new SparkMetadataColumn(MetadataColumns.SPEC_ID.name(),
DataTypes.IntegerType, false),
+ new SparkMetadataColumn(MetadataColumns.PARTITION_COLUMN_NAME,
sparkPartitionType, true),
+ new SparkMetadataColumn(MetadataColumns.FILE_PATH.name(),
DataTypes.StringType, false),
+ new SparkMetadataColumn(MetadataColumns.ROW_POSITION.name(),
DataTypes.LongType, false)
Review comment:
I can match the order in `MetadataColumns` for consistency.
I am not sure how useful `_deleted` metadata column will be in Spark now. I
guess it will be always `false`?
@jackye1995 @chenjunjiedada @RussellSpitzer @rdblue, any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
