rdblue commented on a change in pull request #3379:
URL: https://github.com/apache/iceberg/pull/3379#discussion_r737006057



##########
File path: 
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -87,9 +87,11 @@
   private static final String HIVE_LOCK_CHECK_MIN_WAIT_MS = 
"iceberg.hive.lock-check-min-wait-ms";
   private static final String HIVE_LOCK_CHECK_MAX_WAIT_MS = 
"iceberg.hive.lock-check-max-wait-ms";
   private static final String HIVE_TABLE_LEVEL_LOCK_EVICT_MS = 
"iceberg.hive.table-level-lock-evict-ms";
+  private static final String HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES = 
"iceberg.hive.metadata.refresh.max.retries";

Review comment:
       Iceberg doesn't separate each word using `.`. Each `.` separates the 
hierarchy, but words are separated by `-`. For example, "max-wait-ms" is a 
single concept so we use `-`. But how that wait is scoped uses `.`, like 
`iceberg.hive.lock-check-max-wait-ms`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to