rdblue commented on a change in pull request #3379:
URL: https://github.com/apache/iceberg/pull/3379#discussion_r737006677



##########
File path: 
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java
##########
@@ -434,6 +435,22 @@ public void testEngineHiveEnabledTableProperty() throws 
TException {
     assertHiveEnabled(hmsTable, false);
   }
 
+  @Test(timeout = 60000, expected = NotFoundException.class)

Review comment:
       Can you use `AssertHelpers` instead of `expected`? That allows multiple 
assertions in the test, rather than stopping after an exception is thrown.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to