jzhuge commented on pull request #3188: URL: https://github.com/apache/iceberg/pull/3188#issuecomment-953350659
> Also, if we're capturing what the user wrote, we should probably capture the CREATE VIEW ... part of the command (not just the inner sql). I think this is consistent with how other tools expose the data. @jacques-n Unfortunately it will make it harder for other engine to consume the sql text, e.g., Presto doesn't understand Spark's syntax with column alias. To make it work, we might have to divide CREATE VIEW text into 2 parts, 1 for sql text, 1 for the rest. However, since CREATE VIEW syntax is fairly stable for years, field `sql` and optional `field-*` should be enough to re-create the CREATE VIEW statement in different engines. We can add more optional field to support new syntax down the road. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
