yyanyy commented on a change in pull request #3352:
URL: https://github.com/apache/iceberg/pull/3352#discussion_r737938161
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
##########
@@ -47,6 +55,14 @@ private IcebergToGlueConverter() {
private static final Pattern GLUE_DB_PATTERN =
Pattern.compile("^[a-z0-9_]{1,252}$");
private static final Pattern GLUE_TABLE_PATTERN =
Pattern.compile("^[a-z0-9_]{1,255}$");
+ public static final String ICEBERG_FIELD_USAGE = "iceberg.field.usage";
+ public static final String ICEBERG_FIELD_TYPE_ID = "iceberg.field.type.id";
+ public static final String ICEBERG_FIELD_TYPE_STRING =
"iceberg.field.type.string";
+ public static final String ICEBERG_FIELD_ID = "iceberg.field.id";
Review comment:
I'm having a mixed feeling about putting partition fields the same way
as actual schema columns with the `columns` construct of `StorageDescriptor`
since they are not really table columns, but I'm not sure if there's other
places that we can put such information. Looks like Glue allows configuring
partitionKey, can you remind me why we couldn't use that?
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
##########
@@ -47,6 +55,14 @@ private IcebergToGlueConverter() {
private static final Pattern GLUE_DB_PATTERN =
Pattern.compile("^[a-z0-9_]{1,252}$");
private static final Pattern GLUE_TABLE_PATTERN =
Pattern.compile("^[a-z0-9_]{1,255}$");
+ public static final String ICEBERG_FIELD_USAGE = "iceberg.field.usage";
+ public static final String ICEBERG_FIELD_TYPE_ID = "iceberg.field.type.id";
Review comment:
nit: id sounds like a number, although I'm not sure if
"iceberg.field.type.name" would actually be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
