ConeyLiu commented on a change in pull request #3411:
URL: https://github.com/apache/iceberg/pull/3411#discussion_r738892510
##########
File path: core/src/main/java/org/apache/iceberg/Partitioning.java
##########
@@ -228,11 +229,22 @@ public static StructType partitionType(Table table) {
fieldMap.put(fieldId, field);
NestedField structField = spec.partitionType().field(fieldId);
structFields.add(structField);
+
Review comment:
For v1 format, the dropped partition will be replaced with void
transform. For example, `bucket(2, string_column)` will be replaced with
`void`. However, the type of bucket transform is int, while the type of the
void transform is the original field type. So, we get failed.
The common type of dropped partition and the void transform should be the
first. So, we replace the void transform with the original transform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
