jun-he commented on a change in pull request #3383: URL: https://github.com/apache/iceberg/pull/3383#discussion_r738970691
########## File path: python/tests/utils/test_bin_packing.py ########## @@ -17,34 +17,76 @@ import random -from iceberg.utils.bin_packing import PackingIterator import pytest +from iceberg.utils.bin_packing import PackingIterator + [email protected]("splits, lookback, split_size, open_cost", [ Review comment: 👌 I feel it is good to have it here to help us to keep the code consistent. We can tune the settings to ensure it does the right thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
