samredai commented on a change in pull request #3383:
URL: https://github.com/apache/iceberg/pull/3383#discussion_r739478011
##########
File path: python/tox.ini
##########
@@ -93,7 +125,7 @@ commands =
python -m http.server {posargs}
[flake8]
-ignore = E501,W503
+ignore = E501,E721,I100,I101,I202,W503
Review comment:
The `I` ones are the suggested ones to prevent conflicting with isort
and should also include `I201` but I totally agree, let's add them when once
they cause the tests to fail. Updating now.
*EDIT*: @jun-he I just ran tox and it did fail with `I100` and `I202` so I
kept those in. Did you include the isort linting when you tested it out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
