kbendick commented on a change in pull request #3416:
URL: https://github.com/apache/iceberg/pull/3416#discussion_r739437733
##########
File path:
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilterTypes.java
##########
@@ -135,8 +134,17 @@
DateTimeFormatter.ISO_LOCAL_DATE_TIME);
private static final byte[] fixed = "abcd".getBytes(StandardCharsets.UTF_8);
+ @Rule
+ public TemporaryFolder temp = new TemporaryFolder();
+
+ private File orcFile;
+ private File parquetFile;
Review comment:
Do we need two separate variables for `orcFile` and `parquetFile`?
It seems like the tests only run on one or the other at a time.
But also, I understand if you don't want to have to reorganize the tests too
much. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
