kbendick commented on a change in pull request #3416:
URL: https://github.com/apache/iceberg/pull/3416#discussion_r739439274
##########
File path:
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilterTypes.java
##########
@@ -173,48 +181,36 @@ public void createInputFile() throws IOException {
}
public void createOrcInputFile(List<Record> records) throws IOException {
- if (ORC_FILE.exists()) {
- Assert.assertTrue(ORC_FILE.delete());
- }
Review comment:
From my experience with this, the file won't write if it already exists.
So you can either create a directory and then create a file underneath to
write to, or to keep things simple and just keep the present exists / delete
(which will still ensure that the file clean up happens properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
