kbendick commented on a change in pull request #3326:
URL: https://github.com/apache/iceberg/pull/3326#discussion_r739867916
##########
File path: core/src/main/java/org/apache/iceberg/CatalogUtil.java
##########
@@ -55,12 +54,6 @@
* <li>hadoop: org.apache.iceberg.hadoop.HadoopCatalog</li>
* </ul>
*/
- public static final String ICEBERG_CATALOG_TYPE = "type";
- public static final String ICEBERG_CATALOG_TYPE_HADOOP = "hadoop";
- public static final String ICEBERG_CATALOG_TYPE_HIVE = "hive";
- public static final String ICEBERG_CATALOG_HIVE =
"org.apache.iceberg.hive.HiveCatalog";
- public static final String ICEBERG_CATALOG_HADOOP =
"org.apache.iceberg.hadoop.HadoopCatalog";
Review comment:
+1. People maintaining forks won't necessarily immediately cherry-pick
this PR and it could then break their builds if they reference them.
##########
File path: core/src/main/java/org/apache/iceberg/CatalogUtil.java
##########
@@ -55,12 +54,6 @@
* <li>hadoop: org.apache.iceberg.hadoop.HadoopCatalog</li>
* </ul>
*/
- public static final String ICEBERG_CATALOG_TYPE = "type";
- public static final String ICEBERG_CATALOG_TYPE_HADOOP = "hadoop";
- public static final String ICEBERG_CATALOG_TYPE_HIVE = "hive";
- public static final String ICEBERG_CATALOG_HIVE =
"org.apache.iceberg.hive.HiveCatalog";
- public static final String ICEBERG_CATALOG_HADOOP =
"org.apache.iceberg.hadoop.HadoopCatalog";
Review comment:
+1. People maintaining forks won't necessarily immediately cherry-pick
this PR and it could then break their builds if they reference them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
