kbendick commented on a change in pull request #3326:
URL: https://github.com/apache/iceberg/pull/3326#discussion_r739864409
##########
File path: core/src/main/java/org/apache/iceberg/CatalogUtil.java
##########
@@ -208,23 +201,14 @@ public static Catalog loadCatalog(
*/
public static Catalog buildIcebergCatalog(String name, Map<String, String>
options, Configuration conf) {
String catalogImpl = options.get(CatalogProperties.CATALOG_IMPL);
+ String catalogType = options.get(CatalogProperties.CATALOG_TYPE);
+ Preconditions.checkArgument(catalogImpl == null || catalogType == null,
+ "Cannot create catalog %s, both type and catalog-impl are set:
type=%s, catalog-impl=%s",
Review comment:
Oh you're right about `type` being an existing Spark config 😅. I had
been working too much in Flink when I first looked at this. My bad. I suppose
that reaffirms my thinking that differing configs can be a little confusing,
but it's nothing we have control over at this point without a large refactor
that's probably not worth it.
In regards to changing the Flink catalog, the need to use `type = iceberg`
is something that I believe is mandated by Flink. So I don't think it will be
possible to change that aspect. Over there, the equivalent key is
`catalog-type`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
