rdblue commented on a change in pull request #3387:
URL: https://github.com/apache/iceberg/pull/3387#discussion_r739875358
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -244,4 +244,13 @@ private TableProperties() {
public static final String UPSERT_MODE_ENABLE = "write.upsert.enable";
public static final boolean UPSERT_MODE_ENABLE_DEFAULT = false;
+
+ public static final String REWRITE_PARTIAL_PROGRESS_ENABLED =
"rewrite.partial-progress.enabled";
+ public static final String REWRITE_PARTIAL_PROGRESS_MAX_COMMITS =
"rewrite.partial-progress.max-commits";
+ public static final String REWRITE_MAX_FILE_GROUP_SIZE_BYTES =
"rewrite.max-file-group-size-bytes";
Review comment:
These are still bin-pack options, right? Sort is a subtype of bin
packing. My concern is that other strategies may not respect these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
