rdblue commented on pull request #3387: URL: https://github.com/apache/iceberg/pull/3387#issuecomment-955791800
The changes here look correct to me. My main concern in doing this is creating more table configs that are tied to some specific action and possibly just one action implementation. Are we reasonably confident that these are applicable to other implementations of the action? What about to other rewrite implementations like Netflix's AutoOptimize? One thing that you may want to consider is changing this from encoding rewrite configuration in table properties to being able to set action settings in table properties. We could define a name for each action, like `rewrite-files` and support table properties of the form `actions.<action-name>.<action-config>`. Here, that would be like `actions.rewrite-files.partial-progress.enabled`. That scopes the settings enough that we don't need to decide whether these apply in all situations right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
