rdblue commented on pull request #3373:
URL: https://github.com/apache/iceberg/pull/3373#issuecomment-955808019


   > If a table column and a metadata column have the same name, the metadata 
column will never be requested. Currently we have very simple names for Iceberg 
metadata columns. I wonder if we should make it more complex on engine side, 
such as _iceberg_partition instead of just _partition. Any thoughts?
   
   Sorry I didn't see this ongoing discussion before I merged. If everyone is 
okay with it, let's continue to discuss and address it in a follow-up. At least 
that way we unblock Anton's other work.
   
   I would be fine adding a way to detect this case and change the column name. 
Or just waiting for someone to complain. I doubt many people are using 
`_partition` so it may be better just to wait until someone hits it in practice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to