openinx commented on a change in pull request #3240:
URL: https://github.com/apache/iceberg/pull/3240#discussion_r739996918
##########
File path: flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java
##########
@@ -261,7 +262,7 @@ private Table createTable(String tableName, List<String>
key, boolean isPartitio
private void testSqlChangeLog(String tableName,
List<String> key,
List<List<Row>> inputRowsPerCheckpoint,
- List<List<Record>>
expectedRecordsPerCheckpoint) throws Exception {
+ List<List<Row>> expectedRecordsPerCheckpoint)
throws Exception {
Review comment:
Yeah, the returned data from flink SQL query are collection with `Row`
types, it's good to convert all the `Record` to `Row` for equality checking
purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
