Reo-LEI commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r740134462
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -108,6 +123,15 @@ protected long pos(T record) {
return (Long) posAccessor.get(asStructLike(record));
}
+ private ExecutorService readDeletesService(int workerPoolSize) {
+ return MoreExecutors.getExitingExecutorService(
+ (ThreadPoolExecutor) Executors.newFixedThreadPool(
+ workerPoolSize,
+ new ThreadFactoryBuilder()
+ .setNameFormat("Read-delete-Service-%d")
+ .build()));
+ }
Review comment:
I make this executor service as static. Now, different filter task can
share the same executor service, and we don't need to consider when we should
shutdown and cleaned up the executor service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
