Reo-LEI commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r740137405
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -67,7 +74,11 @@
private final Schema requiredSchema;
private final Accessor<StructLike> posAccessor;
- protected DeleteFilter(FileScanTask task, Schema tableSchema, Schema
requestedSchema) {
+ private int readDeletesWorkerPoolSize;
+ private ExecutorService readDeletesService;
+
+ protected DeleteFilter(FileScanTask task, Schema tableSchema, Schema
requestedSchema,
+ Map<String, String> tableProperties) {
Review comment:
I think `DeleteFilter` should make sure the reader will read delete
files in parallel by itself, if we config it, but not pass a executor service
by the caller. So I create the read service internally, and read the config
from system properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
