RussellSpitzer commented on a change in pull request #3421:
URL: https://github.com/apache/iceberg/pull/3421#discussion_r740238047
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -743,19 +743,23 @@ private PartitionSpec reassignPartitionIds(PartitionSpec
partitionSpec, TypeUtil
} else {
// for v1, preserve the existing spec and carry forward all fields,
replacing missing fields with void
- Map<Pair<Integer, String>, PartitionField> newFields =
Maps.newLinkedHashMap();
+ Map<Integer, PartitionField> newFields = Maps.newLinkedHashMap();
for (PartitionField newField : partitionSpec.fields()) {
- newFields.put(Pair.of(newField.sourceId(),
newField.transform().toString()), newField);
+ newFields.put(newField.sourceId(), newField);
}
for (PartitionField field : spec().fields()) {
// ensure each field is either carried forward or replaced with void
- PartitionField newField = newFields.remove(Pair.of(field.sourceId(),
field.transform().toString()));
Review comment:
Huh some how I pushed but github did not realize it was this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
