rdblue commented on a change in pull request #3421:
URL: https://github.com/apache/iceberg/pull/3421#discussion_r740343482
##########
File path: core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java
##########
@@ -242,7 +242,7 @@ public PartitionSpec apply() {
// field IDs were not required for v1 and were assigned sequentially
in each partition spec starting at 1,000.
// to maintain consistent field ids across partition specs in v1
tables, any partition field that is removed
// must be replaced with a null transform. null values are always
allowed in partition data.
- builder.add(field.sourceId(), field.fieldId(), field.name(),
Transforms.alwaysNull());
+ builder.add(field.sourceId(), field.fieldId(), field.name() + "_" +
field.fieldId(), Transforms.alwaysNull());
Review comment:
I think that this is consistent for us, but causes unexpected changes
for users because columns they don't expect to change will be renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
