rdblue commented on a change in pull request #3399: URL: https://github.com/apache/iceberg/pull/3399#discussion_r740366165
########## File path: python/src/iceberg/expressions.py ########## @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from enum import Enum + +from iceberg.exceptions import OperationError + + +class Operation(Enum): + """Operations to be used as components in expressions + + Various operations can be negated or reversed. Negating an + operation is as simple as using the built-in subtraction operator: + + >>> print(-Operation.TRUE) + Operation.FALSE + >>> print(-Operation.IS_NULL) + Operation.NOT_NULL + + Reversing an operation can be done using the built-in reversed() method: + >>> print(reversed(Operation.LT)) + Operation.GT + >>> print(reversed(Operation.EQ)) + Operation.NOT_EQ + + Raises: + OperationError: This is raised when attempting to negate or reverse + an operation that cannot be negated or reversed. + """ + TRUE = "TRUE" Review comment: Why do we need readable values? The names are already readable. The first option looks like what we do in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
