rdblue commented on a change in pull request #3449:
URL: https://github.com/apache/iceberg/pull/3449#discussion_r741392869
##########
File path: site/mkdocs.yml
##########
@@ -75,21 +75,26 @@ nav:
- Maintenance: maintenance.md
- Performance: performance.md
- Reliability: reliability.md
- - Engines:
- - Spark:
- - Getting Started: getting-started.md
- - Configuration: spark-configuration.md
- - DDL: spark-ddl.md
- - Queries: spark-queries.md
- - Writes: spark-writes.md
- - Maintenance Procedures: spark-procedures.md
- - Structured Streaming: spark-structured-streaming.md
- - Flink:
- - Getting Started: flink.md
- - Flink Connector: flink-connector.md
- - Hive: hive.md
- - Trino: https://trino.io/docs/current/connector/iceberg.html
- - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
+ - Spark:
+ - Getting Started: getting-started.md
+ - Configuration: spark-configuration.md
+ - DDL: spark-ddl.md
+ - Queries: spark-queries.md
+ - Writes: spark-writes.md
+ - Maintenance Procedures: spark-procedures.md
+ - Structured Streaming: spark-structured-streaming.md
+ - Flink:
+ - Getting Started: flink.md
+ - Flink Connector: flink-connector.md
+ - Hive:
Review comment:
Hive isn't that long of a page right now. Why split it out in this
commit rather than just leaving it as-is and having a high-level link to the
page? If we leave it as-is then we don't need to worry about permalinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
