samredai commented on a change in pull request #3449:
URL: https://github.com/apache/iceberg/pull/3449#discussion_r741963948
##########
File path: site/mkdocs.yml
##########
@@ -75,21 +75,26 @@ nav:
- Maintenance: maintenance.md
- Performance: performance.md
- Reliability: reliability.md
- - Engines:
- - Spark:
- - Getting Started: getting-started.md
- - Configuration: spark-configuration.md
- - DDL: spark-ddl.md
- - Queries: spark-queries.md
- - Writes: spark-writes.md
- - Maintenance Procedures: spark-procedures.md
- - Structured Streaming: spark-structured-streaming.md
- - Flink:
- - Getting Started: flink.md
- - Flink Connector: flink-connector.md
- - Hive: hive.md
- - Trino: https://trino.io/docs/current/connector/iceberg.html
- - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
+ - Spark:
+ - Getting Started: getting-started.md
+ - Configuration: spark-configuration.md
+ - DDL: spark-ddl.md
+ - Queries: spark-queries.md
+ - Writes: spark-writes.md
+ - Maintenance Procedures: spark-procedures.md
+ - Structured Streaming: spark-structured-streaming.md
+ - Flink:
+ - Getting Started: flink.md
+ - Flink Connector: flink-connector.md
+ - Hive:
Review comment:
This was really just to make the drop-downs look consistent but I'm
realizing that issue partially goes away now that everything is flat. I'll
consolidate the hive section back into a single file.
##########
File path: site/mkdocs.yml
##########
@@ -75,21 +75,26 @@ nav:
- Maintenance: maintenance.md
- Performance: performance.md
- Reliability: reliability.md
- - Engines:
- - Spark:
- - Getting Started: getting-started.md
- - Configuration: spark-configuration.md
- - DDL: spark-ddl.md
- - Queries: spark-queries.md
- - Writes: spark-writes.md
- - Maintenance Procedures: spark-procedures.md
- - Structured Streaming: spark-structured-streaming.md
- - Flink:
- - Getting Started: flink.md
- - Flink Connector: flink-connector.md
- - Hive: hive.md
- - Trino: https://trino.io/docs/current/connector/iceberg.html
- - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
+ - Spark:
+ - Getting Started: getting-started.md
+ - Configuration: spark-configuration.md
+ - DDL: spark-ddl.md
+ - Queries: spark-queries.md
+ - Writes: spark-writes.md
+ - Maintenance Procedures: spark-procedures.md
+ - Structured Streaming: spark-structured-streaming.md
+ - Flink:
+ - Getting Started: flink.md
+ - Flink Connector: flink-connector.md
+ - Hive:
Review comment:
Updated! Hive is now a single top level item that points to `hive.md`
and renders the whole page when you click on it.
<img width="1780" alt="Screen Shot 2021-11-03 at 7 38 43 AM"
src="https://user-images.githubusercontent.com/43911210/140081434-d9c19073-5d0d-434d-8654-a73c99ec68d9.png";>
.
##########
File path: site/mkdocs.yml
##########
@@ -75,21 +75,26 @@ nav:
- Maintenance: maintenance.md
- Performance: performance.md
- Reliability: reliability.md
- - Engines:
- - Spark:
- - Getting Started: getting-started.md
- - Configuration: spark-configuration.md
- - DDL: spark-ddl.md
- - Queries: spark-queries.md
- - Writes: spark-writes.md
- - Maintenance Procedures: spark-procedures.md
- - Structured Streaming: spark-structured-streaming.md
- - Flink:
- - Getting Started: flink.md
- - Flink Connector: flink-connector.md
- - Hive: hive.md
- - Trino: https://trino.io/docs/current/connector/iceberg.html
- - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
+ - Spark:
+ - Getting Started: getting-started.md
+ - Configuration: spark-configuration.md
+ - DDL: spark-ddl.md
+ - Queries: spark-queries.md
+ - Writes: spark-writes.md
+ - Maintenance Procedures: spark-procedures.md
+ - Structured Streaming: spark-structured-streaming.md
+ - Flink:
+ - Getting Started: flink.md
+ - Flink Connector: flink-connector.md
+ - Hive:
Review comment:
This was really just to make the drop-downs look consistent but I'm
realizing that issue partially goes away now that everything is flat. I'll
consolidate the hive section back into a single file.
##########
File path: site/mkdocs.yml
##########
@@ -75,21 +75,26 @@ nav:
- Maintenance: maintenance.md
- Performance: performance.md
- Reliability: reliability.md
- - Engines:
- - Spark:
- - Getting Started: getting-started.md
- - Configuration: spark-configuration.md
- - DDL: spark-ddl.md
- - Queries: spark-queries.md
- - Writes: spark-writes.md
- - Maintenance Procedures: spark-procedures.md
- - Structured Streaming: spark-structured-streaming.md
- - Flink:
- - Getting Started: flink.md
- - Flink Connector: flink-connector.md
- - Hive: hive.md
- - Trino: https://trino.io/docs/current/connector/iceberg.html
- - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
+ - Spark:
+ - Getting Started: getting-started.md
+ - Configuration: spark-configuration.md
+ - DDL: spark-ddl.md
+ - Queries: spark-queries.md
+ - Writes: spark-writes.md
+ - Maintenance Procedures: spark-procedures.md
+ - Structured Streaming: spark-structured-streaming.md
+ - Flink:
+ - Getting Started: flink.md
+ - Flink Connector: flink-connector.md
+ - Hive:
Review comment:
Updated! Hive is now a single top level item that points to `hive.md`
and renders the whole page when you click on it.
<img width="1780" alt="Screen Shot 2021-11-03 at 7 38 43 AM"
src="https://user-images.githubusercontent.com/43911210/140081434-d9c19073-5d0d-434d-8654-a73c99ec68d9.png";>
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/43911210/140081434-d9c19073-5d0d-434d-8654-a73c99ec68d9.png"](https://user-images.githubusercontent.com/43911210/140081434-d9c19073-5d0d-434d-8654-a73c99ec68d9.png"){kind=link}