kbendick commented on a change in pull request #3424: URL: https://github.com/apache/iceberg/pull/3424#discussion_r741484524
########## File path: api/src/main/java/org/apache/iceberg/rest/CreateNamespaceRequest.java ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest; + +import java.io.Serializable; +import java.util.Map; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; + +/** + * Represents a REST request to create a namespace / database. + */ +public class CreateNamespaceRequest implements Serializable { + + // TODO - Use protected so users can extend this for their own impls. Or an interface. + // Currently anything but private causes an error. + private String namespaceName; + private Map<String, String> properties; + + private CreateNamespaceRequest() { + + } + + private CreateNamespaceRequest(String namespaceName, Map<String, String> properties) { + this.namespaceName = namespaceName; + this.properties = properties; + } + + /** + * Name of the database to create. + */ + String getNamespaceName() { + return namespaceName; + } + + void setNamespaceName(String name) { + this.namespaceName = name; Review comment: Yeah. I also prefer documenting the JSON objects. I had thought that the getters and setters were still needed for the serializers though. But I'm relatively green with the Apache HTTP library that I chose for the reference calls, so maybe I can get rid of this. I'll play around with it, but definitely agreed that I prefer to specify the protocol and to keep it language agnostic (e.g. so people can use another language on the server side in addition to the clarity that documenting the JSON objects brings over the Java classes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
