kbendick commented on a change in pull request #3424:
URL: https://github.com/apache/iceberg/pull/3424#discussion_r744100029



##########
File path: api/src/main/java/org/apache/iceberg/rest/CreateNamespaceRequest.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.rest;
+
+import java.io.Serializable;
+import java.util.Map;
+import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+
+/**
+ * Represents a REST request to create a namespace / database.
+ */
+public class CreateNamespaceRequest implements Serializable {
+
+  // TODO - Use protected so users can extend this for their own impls. Or an 
interface.
+  //        Currently anything but private causes an error.
+  private String namespaceName;
+  private Map<String, String> properties;
+
+  private CreateNamespaceRequest() {
+
+  }
+
+  private CreateNamespaceRequest(String namespaceName, Map<String, String> 
properties) {
+    this.namespaceName = namespaceName;
+    this.properties = properties;
+  }
+
+  /**
+   * Name of the database to create.
+   */
+  String getNamespaceName() {
+    return namespaceName;
+  }
+
+  void setNamespaceName(String name) {
+    this.namespaceName = name;

Review comment:
       Admittedly, as I come from more of a Scala background (partcularly when 
implementing REST API clients), in some places I'm not sure what needs to be a 
bean and what doesn't for serialization. I've typically relied on case classes, 
which can pretty effortlessly be converted to and from JSON with much work, or 
more modern over the network serialization standards such as protobuf, thrift, 
or even Avro.
   
   So some things might presently be beans that don't need to be. I'm happy to 
clean that up as I go along and come to be more familiar with some of these 
java bean related things =)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to