rdblue commented on a change in pull request #3460:
URL: https://github.com/apache/iceberg/pull/3460#discussion_r742283725
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/SparkTestBase.java
##########
@@ -157,7 +158,11 @@ private void assertEquals(String context, Object[]
expectedRow, Object[] actualR
Object actualValue = actualRow[col];
if (expectedValue != null && expectedValue.getClass().isArray()) {
String newContext = String.format("%s (nested col %d)", context, col +
1);
- assertEquals(newContext, (Object[]) expectedValue, (Object[])
actualValue);
+ if (expectedValue.getClass().getComponentType().isPrimitive()) {
+ new ExactComparisonCriteria().arrayEquals(newContext, expectedValue,
actualValue);
+ } else {
+ assertEquals(newContext, (Object[]) expectedValue, (Object[])
actualValue);
+ }
Review comment:
Why was this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
